V3 Nested sub ifds parsing fix #2913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the nested sub-IFDs parsing fix for JPEG metadata by introducing new tests to verify correct parsing and updating the underlying EXIF reader logic.
- Added a new test case for issue 2857 in the JPEG test suite.
- Updated ExifReader logic to process nested sub-IFDs with batch limits and improved duplicate checking.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ImageSharp.Tests/TestImages.cs | Added constant for test image issue 2857. |
| tests/ImageSharp.Tests/Formats/Jpg/JpegDecoderTests.Metadata.cs | Introduced new test method for validating sub-IFDs parsing along with various EXIF metadata assertions. |
| src/ImageSharp/Metadata/Profiles/Exif/ExifReader.cs | Modified sub-ifd reading loop with batch processing and adjusted duplicate comparison logic. |
Files not reviewed (1)
- tests/Images/Input/Jpg/issues/issue-2857-subsub-ifds.jpg: Language not supported
Comments suppressed due to low confidence (1)
src/ImageSharp/Metadata/Profiles/Exif/ExifReader.cs:198
- [nitpick] Consider renaming variable 'sz' to 'batchSize' for improved clarity.
int sz = Math.Min(this.subIfds.Count, maxSubIfds);
This was referenced Jul 28, 2025
This was referenced Jul 30, 2025
This was referenced Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Reimplement of #2869 for v3.