V3: Do not attempt to decode iDAT chunks when image is fully decoded. #2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR backports a fix for issue #2924 to v3.1.x, ensuring that iDAT chunks are not decoded once the image is fully processed.
- Adds new test images and a constant for Issue2924 to the test assets.
- Introduces a new unit test in PngDecoderTests to validate the fix.
- Updates PngDecoderCore by adding a flag (hasImageData) and refactoring control flow with goto EXIT statements to set that flag.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Images/Input/Png/issues/Issue_2924.png | Added test image metadata for issue 2924 |
| tests/Images/External/ReferenceOutput/PngDecoderTests/CanDecode_Issue2924_Rgba32_Issue_2924.png | Added reference output image for issue 2924 |
| tests/ImageSharp.Tests/TestImages.cs | Added a constant for the new issue-specific test image |
| tests/ImageSharp.Tests/Formats/Png/PngDecoderTests.cs | Added a new unit test for verifying the decoding fix |
| src/ImageSharp/Formats/Png/PngDecoderCore.cs | Introduced hasImageData flag and refactored control flow to prevent decoding iDAT chunks when the image is complete |
This was referenced Jul 23, 2025
This was referenced Jul 30, 2025
This was referenced Jul 30, 2025
This was referenced Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #2924
Backport of #2926 for v3.1.x