Adds missing lang entries for bundle inventory actions and bucket spawn reason #7776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curious what you meant by this? |
getAction seems to always return PLACE_ALL from my testing my bad i committed the cardinal sin of testing ICE in creative lmao |
yeah I was about to say. I filed the issue because of a convo on paper, and yeah in creative it just shows PLACE_ALL |
APickledWalrus
approved these changes
Apr 5, 2025
| @@ -2144,6 +2150,7 @@ spawn reasons: | |||
| bed: bed | |||
| beehive: beehive | |||
| breeding: breed, breeding | |||
| bucket: release from bucket # 'bucket' alone is problematic | |||
There was a problem hiding this comment.
Efnilite
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds lang entries for 1.21.4+ bundle inventory actions
(These actions appear to be unused as of Paper 1.21.4-222).Adds entry for
bucketspawn reason. Due to conflicts, I choserelease from bucketas the full entry. Suggestions welcome.Target Minecraft Versions: any
Requirements: none
Related Issues: #7772