Fix expression section claim releasing #8082
Merged
+15
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When parsing a statement, if it contained a section expression, and that section expression successfully parsed and claimed a section (but the statement itself failed in init), the claim on the section would not be released. As a result, any future attempts to parse a section expression would fail as it believed the section to already be claimed.
Solution
When a section expression may be parsed, the Statement iterator is wrapped such that the "owner" of the section context is cleared when the next element of the iterator is returned.
Testing Completed
tested in game using a combination of addons that exposed the issue. testing is a bit complex as it would require usage of priorities which isn't currently possible with test syntax. if it is really wanted i can probably make it happen
Supporting Information
Completes: none
Related: none