Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PyMySQL/mysqlclient
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: SpamExperts/mysqlclient-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 8 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 27, 2016

  1. Configuration menu
    Copy the full SHA
    d30d54c View commit details
    Browse the repository at this point in the history
  2. Load SSL options from the environment.

    - Remove the previous generic option loading, which wouldn't work for
    SSL (because we need a dictionary) and that was all we really cared
    about.
    
     - Load the various SSL options from the environment if they are
    present and not in the arguments.
    
     - Skip this for any localhost connection because TLS doesn't make
    sense there.
    tonyandrewmeyer committed Oct 27, 2016
    Configuration menu
    Copy the full SHA
    b86c0d2 View commit details
    Browse the repository at this point in the history
  3. Provide the ability to explicitly say no-ssl.

    If ssl is not missing but =None, then do not do the environment load.
    
    
    
    The currently behaviour has ssl=None fail when it tries to make a TLS
    connection, so this shouldn't break anything, and allows the system to
    be bypassed when needed.
    tonyandrewmeyer committed Oct 27, 2016
    Configuration menu
    Copy the full SHA
    0034180 View commit details
    Browse the repository at this point in the history
  4. Always skip SSL if host=localhost.

    If we are making a connection to localhost, then passing anything for
    SSL will always mean a failed connection, because a certificate cannot
    be verified (if TCP/IP) or SSL doesn't make sense (if UNIX).
    
    
    
    Make it easier to call connect with ssl values by always ignoring them
    in the localhost case. This means that callers do not need to check if
    the host is localhost and can simply always provide an SSL value (e.g.
    if the host is a variable).
    tonyandrewmeyer committed Oct 27, 2016
    Configuration menu
    Copy the full SHA
    88b50c1 View commit details
    Browse the repository at this point in the history
  5. Fix whitespace.

    tonyandrewmeyer committed Oct 27, 2016
    Configuration menu
    Copy the full SHA
    fddbc19 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2016

  1. Typo

    tonyandrewmeyer committed Oct 28, 2016
    Configuration menu
    Copy the full SHA
    55a47bb View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Merge branch 'master' of https://github.com/PyMySQL/mysqlclient-python

    …into MMA-3573
    Silviu Surcica committed May 14, 2020
    Configuration menu
    Copy the full SHA
    d8890cf View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Merge pull request #2 from SpamExperts/MMA-3573

    MMA-3573. Update from upstream
    silviu.surcica authored May 15, 2020
    Configuration menu
    Copy the full SHA
    426342a View commit details
    Browse the repository at this point in the history
Loading