Skip to content

[BUG] detail/summary not rendered correctly in latest version with HtmlExtension #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arjanmels opened this issue May 19, 2023 · 3 comments
Closed

[BUG] detail/summary not rendered correctly in latest version with HtmlExtension #1275

arjanmels opened this issue May 19, 2023 · 3 comments
Labels
bug Something isn't working whitespace issues
Milestone
3.0.0

Comments

@arjanmels
Copy link
Contributor

Describe the bug:
After transition to HtmlExtension the details/summary tags sometimes show "Details" instead of the summary provided in the summary tag.
Debugged in the code: due to context.builtChildrenMap in DetailsElementBuiltIn build function containing "[text]" element as first child instead of summary.

HTML to reproduce the issue:

<!DOCTYPE html>
<html>
<body>
<details>
  <summary><h1>Header</h1></summary>
  <p>These are the details.</p>
</details>
</body>
</html>

Html widget configuration:
Not relevant

Expected behavior:
Should show the "Header" text instead of "Details"

Device details and Flutter/Dart/flutter_html versions:
Flutter 3.10.1 / Dart 3.0.1
@arjanmels arjanmels added the bug Something isn't working label May 19, 2023
@arjanmels
Copy link
Contributor Author

I'm guessing commit cc00406 does not work completely as expected.

@arjanmels arjanmels mentioned this issue May 19, 2023
Merged
@arjanmels
Copy link
Contributor Author

Fixed by #1276

@Sub6Resources
Copy link
Owner

Thanks for the contribution! Just made a comment on your pull request.

@Sub6Resources Sub6Resources added this to the 3.0.0 milestone May 23, 2023
@Sub6Resources Sub6Resources moved this to Done in flutter_html Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working whitespace issues
Projects
flutter_html
Status: Done
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@Sub6Resources @arjanmels