Skip to content

Nullsafety #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sma opened this issue Dec 12, 2020 · 9 comments · Fixed by #548
Closed

Nullsafety #468

sma opened this issue Dec 12, 2020 · 9 comments · Fixed by #548

Comments

@sma
Copy link

sma commented Dec 12, 2020

I converted the project to NNBD and can provide a pull request.

According to flutter pub outdated --mode=null-safety these packages still lack NNBD support, therefore, I suppressed the import_of_legacy_library_into_null_safe warning: chewie, chewie_audio, csslib, html, webview_flutter.

csslib is already ported, but no nullsafety version was published to pub yet. The same is true for html.

I haven't checked the status of chewie, but the underlying video_player package is already ported as well as wakelock.
@ryan-berger
Copy link
Contributor

@sma A port to null safety would be much appreciated as I understand we are hurtling towards the day that the Flutter team enforces it.

If you submit a PR I can review it and make sure we are good to go

@erickok
Copy link
Contributor

erickok commented Feb 8, 2021

We at least need to update with support for Flutter 1.26 (see #531 for an attempt) and then our dependencies with nullsafety. PR is very much welcome!

@jlubeck
Copy link

jlubeck commented Feb 16, 2021

@sma are you still providing the PR for this? Looking forward to it

@sma
Copy link
Author

sma commented Feb 17, 2021

I'm sorry, I didn't respond. I was busy and didn't notice the request. I'll look into it tonight or tomorrow.

@tneotia
Copy link
Contributor

tneotia commented Feb 17, 2021

I had been working on nullsafety since this morning and didn't see that @sma was also still working on his nullsafety port. I've got a PR pushed at #548 but please submit yours as an alternative too! :)
You may need to merge master and redo your nullsafety port since (I'm guessing) you last worked on it in December.

By the way, now we are only waiting on chewie and chewie_audio to be migrated - their dependencies are all migrated. I did a very rushed migration (just updated dependencies and fixed deprecations) in a fork of both libraries. I've pointed pubspec to my GitHub forks with the migration temporarily. This will need to be changed back once those are migrated, of course.

@erickok
Copy link
Contributor

erickok commented Feb 18, 2021

@tneotia I am short for time at the moment. For chewie_audio, can you make a PR there? 'We' also maintain that library.

@tneotia
Copy link
Contributor

tneotia commented Feb 18, 2021 •
edited
Loading

@erickok done: Sub6Resources/chewie_audio#12

@devj3ns
Copy link

devj3ns commented Mar 1, 2021

Hey guys, thanks for your work so far.

Are there any updates on this?

@savs90
Copy link

savs90 commented Mar 4, 2021

Also waiting for the null safety version :) Thanks for the work guys!

@tneotia tneotia mentioned this issue Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nullsafety tneotia/flutter_html
7 participants
@sma @erickok @jlubeck @savs90 @ryan-berger @devj3ns @tneotia