Fix Lists and upgrade List support to CSS3 #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickok
previously approved these changes
Oct 9, 2022
Codecov ReportBase: 49.70% // Head: 51.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1161 +/- ##
==========================================
+ Coverage 49.70% 51.41% +1.71%
==========================================
Files 18 19 +1
Lines 2682 2641 -41
==========================================
+ Hits 1333 1358 +25
+ Misses 1349 1283 -66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@erickok If you wouldn't mind doing a quick rereview on the most recent commit (which re-adds basic |
This was referenced May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
CssBoxWidgetallows us to effectively render a "marker box" on elements, especially list elements. This upgrade fixes almost all of our open list issues. It removes support for custom Widget list markers, since CSS doesn't support that (however, the same functionality could easily be re-added in aCustomRenderby interested parties).This pull request also removes the roman-numeral-specific
numerusdependency in favor of the more generallist_counterdependency (disclosure: package written by myself). This change in dependency allows us to expand our list style support to 54 different list-styles, including dozens of new languages.This pull request fixes the following open and tightly-related issues:
Fixes #1100
Fixes #245
Fixes #984
Fixes #991
Fixes #1016
Fixes #1020
Fixes #1104
This pull request is
a work in progressready to go. Still to do: