Optional properties: selectable, placeholderAlignment. #1191
Conversation
|
Can confirm the fix works on my project, at least to fix the layout issues :) I've noticed my table doesn't scroll (within its single child scroll view) which is another issue but I'll quickly confirm if that's on my end. |
|
Appears there are still some layout regressions with this fix, even though it does improve on laying out otherwise. Tables are now having large amounts of whitespace between columns instead of sizing themselves to match their content + padding. The scrolling behaviour also appears to be a regression, but oddly works slightly better if you add a scroll controller with an intialScrollOffset value. I'll keep investigating but I think this is due to the lack of intrinsic width calculations of the columns with these changes. |
334f083 to
3ae5a60
Compare
|
This solve my issue👍 thanks @darkstarx |
|
I would love to see this pushed into the next alpha release. This issue in particular is what is preventing me from using the alpha releases of the HTML plugin. |
|
I tested this PR. It fixed the Intrinsic issue, and works pretty well. I would like to have it in the master branch, too. |
| flutter_html: | ||
| git: | ||
| url: git@github.com:darkstarx/flutter_html.git | ||
| ref: master |
| flutter_html: | ||
| git: | ||
| url: git@github.com:darkstarx/flutter_html.git | ||
| ref: master |
There was a problem hiding this comment.
Please remove all instances of referencing your own fork
| @@ -62,6 +62,7 @@ class Html extends StatefulWidget { | |||
| this.onImageTap, | |||
| this.tagsList = const [], | |||
| this.style = const {}, | |||
| this.selectable = false, | |||
There was a problem hiding this comment.
We're moving away from SelectableHtml (see #1153). Please remove this selectable parameter from your changes so we can evaluate just the placeholderAlignment portion.
If you're in charge of maintenance of this project, please, take an effort to do all of this changes you mentioned yourself in your repository to eliminate the bug. I won't remove anything from my fork since everything suits me in it. |
To eliminate the issue of using this widget inside the
IntrinsicHeight, we must temporary discard of using baseline alignment. This PR makes this propertybottomby default and still allows to customize the value to keep the widget ready to use when the Flutter issue flutter/flutter#65895 is solved (by configuring theplaceholderAlignmentproperty for specific tags in thestyleproperty). Also it makes the propertyselectablecustomizable as well.