Skip to content

Fix missing headers parameter #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

Fix missing headers parameter #1203

merged 1 commit into from
May 9, 2023

Conversation

ndelanou
Copy link
Contributor

@ndelanou ndelanou commented Dec 7, 2022

When using a networkImageRender(), the header value is not taken into account when computing the image size.
If the headers are used for authentication, the image will never load.

erickok
erickok approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report and fixing the bug yourself. 👍

@Sub6Resources Sub6Resources added this to the 3.0.0 milestone May 9, 2023
@Sub6Resources Sub6Resources merged commit a5f9928 into Sub6Resources:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@erickok erickok erickok approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelanou @erickok @Sub6Resources