Skip to content

Fix: Aspect ratio exception when height is 0 #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

Fix: Aspect ratio exception when height is 0 #1222

merged 1 commit into from
May 9, 2023

Conversation

ib-8
Copy link
Contributor

@ib-8 ib-8 commented Jan 31, 2023 •
edited
Loading

Error: 'package:flutter/src/widgets/basic.dart': Failed assertion: line 3294 pos 15: 'aspectRatio > 0.0': is not true.

When height is 0, aspect ratio error occurs. By returning aspect ratio is 1 when height is 0 then the problem gets solved.

@Sub6Resources Sub6Resources mentioned this pull request May 9, 2023
Closed
Sub6Resources
Sub6Resources approved these changes May 9, 2023
View reviewed changes
Copy link
Owner

@Sub6Resources Sub6Resources left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@Sub6Resources Sub6Resources merged commit ed75f8f into Sub6Resources:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sub6Resources Sub6Resources Sub6Resources approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ib-8 @Sub6Resources