Skip to content

#233: Added supoort for line-height #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2020
Merged

#233: Added supoort for line-height #306

merged 1 commit into from
Sep 5, 2020

Conversation

vanlooverenkoen
Copy link
Contributor

@vanlooverenkoen vanlooverenkoen commented May 29, 2020 •
edited
Loading

#233 implementation

@vanlooverenkoen vanlooverenkoen mentioned this pull request May 29, 2020
Closed
@vanlooverenkoen
Copy link
Contributor Author

@ryan-berger @Sub6Resources @edwardaux any idea when this pr will be reviewed/merged?

@dlpigpen
Copy link

Line height feature is very important when you can support to merge it in the new version?

@DFelten
Copy link
Contributor

DFelten commented Aug 26, 2020

Thanks for this MR! We are now using a fork of flutter_html until this has been merged.

ryan-berger
ryan-berger approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll get this merged tomorrow

@ryan-berger ryan-berger merged commit 85f6446 into Sub6Resources:master Sep 5, 2020
@ryan-berger ryan-berger mentioned this pull request Sep 5, 2020
Closed
@vanlooverenkoen vanlooverenkoen deleted the feature/#233-line-height-support branch October 4, 2020 12:55
@DFelten DFelten mentioned this pull request Oct 14, 2020
Closed
@NemoChen317 NemoChen317 mentioned this pull request Dec 9, 2021
Closed
@Equirinya Equirinya mentioned this pull request Aug 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penniath penniath penniath approved these changes

@ryan-berger ryan-berger ryan-berger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vanlooverenkoen @dlpigpen @DFelten @penniath @ryan-berger