Add support for list-style-position css attribute #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-berger
suggested changes
Jun 10, 2020
There was a problem hiding this comment.
Overall, looks good. Take a look at my other comment for some feedback before this is merged. I haven't run this yet and tested it out, but everything looks great, and I expect it works well.
I'll try to test this out sometime this week, and if everything looks fine and nothing breaks, and your code edits are ready, I'll merge this in along with a couple of other items
ryan-berger
approved these changes
Jun 28, 2020
| textAlign: TextAlign.right, | ||
| style: newContext.style.generateTextStyle()), | ||
| ), | ||
| children: [ |
There was a problem hiding this comment.
Looks much prettier! I'll test this out tomorrow and get it merged
|
Is this now available in dart.dev now? in terms of the update version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the list-style-position CSS attribute. When set to
ListStylePosition.INSIDE, bullets and list numbers will be part of the text and align with it. Fixes #302