Temporary fix for irregular table rows #435
Conversation
|
I am hesitant to merge this, as it only fixes the odd case where not all columns are supplied in the html, yet just filling those missing cells with empty space is sufficient. It does not implement actual colspan support. |
|
Yep that's why I labeled it as temporary. As far as I know, implementing colspan and rowspan will be impossible in flutter or we will have to create a custom widget implementation with the basic row and column widgets. I would leave this open and whoever needs this fix can use this branch in their pubspec |
|
I tried to give this another shot using this package but I just could not figure out how to give each element the colspan and rowspan attribute. In the tree, the These could be super trivial and I may be overthinking them, if someone else wants to give it a go, feel free! |
|
I have tried using flutter_layout_grid as well, but that library doesn't seem to support intrinsic heights at all (despite claiming otherwise). Even their examples would not render on mobile Flutter for me, always throwing 'RenderConstrainedBox object was given an infinite size during layout' errors. 🤷 Using Flutter's I considered flutter_staggered_grid_view but that really works just when it is it's own scroll container. spannable_grid looked promising too, but it actually fixes every cell in the grid to be rectangular. The Flutter isssue asking for colspan/rowspan support is totally dormant. It also doesn't mention any 3th party alternatives. 😡 I guess we have to build something custom... |
|
@erickok can this be closed due to your other PR that I just merged? |
|
Not Eric but yes his solution which you merged is miles better than this one. Closing... |
Possible temporary fix for #242 . Definitely needs testing, but in two test cases this worked fine.
Basically what I did was find the row(s) that had the most number of elements, and store their length.
Then, just before building the table, create a list of empty containers that corresponds to the difference between the length of the row being built and the length of the longest row(s).
Finally, attach that empty container list into the
TableRowchildrenproperty to avoid the irregular sizing error.I left my
printstatements in for debugging if this solution doesn't work for certain cases.