Skip to content

Respect iframe sandbox attribute to enable/disable javascript #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

Respect iframe sandbox attribute to enable/disable javascript #506

merged 1 commit into from
Jan 20, 2021

Conversation

erickok
Copy link
Contributor

@erickok erickok commented Jan 20, 2021

This fixes #473 for the script execution part, so it is technically a partial implementation of the sandbox attribute, but the most important part at least.

@erickok erickok mentioned this pull request Jan 20, 2021
Closed
ryan-berger
ryan-berger approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryan-berger ryan-berger merged commit e5e24d0 into Sub6Resources:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ryan-berger ryan-berger ryan-berger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iframe sandbox attribute with no value not works
2 participants
@erickok @ryan-berger