Skip to content

Fix shrink wrap not applying correctly #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 9, 2021
Merged

Fix shrink wrap not applying correctly #530

merged 6 commits into from
Feb 9, 2021

Conversation

tneotia
Copy link
Contributor

@tneotia tneotia commented Feb 6, 2021 •
edited
Loading

Fixes #290
Possibly fixes #297? Don't quite know what that issue is wanting.

This by itself does not fix the entire issue if the HTML would extend past the page width in the first place. For this to work without fail, people will have to do

Row(
   children: [
	Expanded(
	   child: Html(//params)
	),
	//whatever other widgets
   ]
)

However there is no longer an error when using the widget inside a Row().

@ryan-berger just a note for you, (if this will be merged) please merge this before #507 so I can also apply the renderContext attributes to the code I am using in that PR, then that will be ready to be merged as well.

@tneotia tneotia mentioned this pull request Feb 6, 2021
Merged
@tneotia
Copy link
Contributor Author

tneotia commented Feb 8, 2021

@ryan-berger could you check this one out? #507 is ready as per @erickok , I would like this to be merged beforehand so I can apply the same fixes to the widget rendering code in that PR.

ryan-berger
ryan-berger suggested changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just some simplifications and questions to answer

@tneotia
Copy link
Contributor Author

tneotia commented Feb 8, 2021

@ryan-berger I've made the changes, let me know if there's anything else.

ryan-berger
ryan-berger suggested changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things

@tneotia
Copy link
Contributor Author

tneotia commented Feb 9, 2021

@ryan-berger cleaned that up too. Forgive me, I know these are better ways of styling code but sometimes I get back into that same rut of bad habits when I'm not paying close attention. I'll try to pay more attention from here on out, but bear with me in case I do make these errors every now and then.

@ryan-berger
Copy link
Contributor

@tneotia No problem! I'm definitely not frustrated or mad, just trying to enforce concise code where possible.

ryan-berger
ryan-berger reviewed Feb 9, 2021
View reviewed changes
@ryan-berger ryan-berger merged commit 9327fe9 into Sub6Resources:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-berger ryan-berger ryan-berger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support shrinkToFit property in 1.0.0 In 1.0.0, shrinkWrap: true does not provide a size to the layout engine
2 participants
@tneotia @ryan-berger