Skip to content

Conversation

erickok
Copy link
Contributor

@erickok erickok commented Feb 9, 2021

Updates the readme.

I'm not sure if we should explicitly bump the min Flutter version to 1.26, as practically the required dependencies now really need that, but we apparently didn't do this before?

@ryan-berger
Copy link
Contributor

@erickok I'm not going to make a review out of this, but I forgot to make a comment on the README on the previous PR, but I didn't act quick enough....

I'm not sure how much I like sub-links of Example for every single class we have. I think that it is quite implicit that there will be examples in a README, and we shouldn't need to have those links and it seems to clutter the README. Then we can keep it just a nice list rather than having the clutter of "Example" between each item

@erickok
Copy link
Contributor Author

erickok commented Feb 16, 2021

@ryan-berger could you review this and merge? Then we can finally make a release. Send people really want it.

@ryan-berger
Copy link
Contributor

Yup! I forgot I had to review it. I was wondering why it wasn't merged yet 🙃

Copy link
Contributor

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryan-berger ryan-berger merged commit 705ea53 into Sub6Resources:master Feb 16, 2021
@ryan-berger
Copy link
Contributor

@erickok Go ahead and release if you'd like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants