Upgrade link functions #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickok
reviewed
Feb 22, 2021
| @@ -82,7 +83,16 @@ class ImageContentElement extends ReplacedElement { | |||
| if (entry.key.call(attributes, element)) { | |||
| final widget = entry.value.call(context, attributes, element); | |||
| if (widget != null) { | |||
| return widget; | |||
| return RawGestureDetector( | |||
There was a problem hiding this comment.
Hmmm did we introduce a regression bug where the onImageTap listener was never called?
There was a problem hiding this comment.
I think so, from when you implemented the image renders.
erickok
approved these changes
Feb 22, 2021
tneotia
added a commit
to tneotia/flutter_html
that referenced
this pull request
Feb 24, 2021
erickok
added a commit
that referenced
this pull request
Feb 24, 2021
Fix example app errors due to #541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301 using code:
Maybe providing all those parameters in the OnTap function is too much, so if you disagree then I can try and figure out an alternate way. I thought this would be the best solution since it allows the user to customize down to the lowest level using the same parameters the widgets themselves are built with.