Add support for base64 encoded SVG within img tag #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier all img tags were treated as a png or jpg image. But this PR ensures that img tags with base64 encoded SVG data gets parsed as SvgContentElement
Works on height=789.543, height=789.543pt, height=789.543in etc
erickok
added a commit
to vrtdev/flutter_html
that referenced
this pull request
Feb 22, 2021
This supports SVG as base64 encoded data blob or inline tags. This is an alternative to Sub6Resources#550 which did not use the new image API at all.
|
I'm sorry but we just introduced an image API just for use-cases like this. Having said that, the request is so reasonable that first-party support is warranted and I've added exactly that in #551. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier all img tags were treated as a png or jpg image. But this PR ensures that img tags with base64 encoded SVG data gets parsed as SvgContentElement