Skip to content

Fix issue #590：type 'List<Expression>' is not a subtype of type 'List… #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2021
Merged

Fix issue #590：type 'List<Expression>' is not a subtype of type 'List… #591

merged 1 commit into from
Mar 22, 2021

Conversation

windows7lake
Copy link
Contributor

Fix issue #590：type 'List' is not a subtype of type 'List' in type cast

erickok
erickok approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks for the fix.

@erickok erickok merged commit b792d06 into Sub6Resources:master Mar 22, 2021
@tneotia tneotia mentioned this pull request Mar 22, 2021
Closed
@MuhammadSufyanMalik
Copy link

Hi,
I am alos getting this error,
type 'List' is not a subtype of type 'List' in type cast
I tried by adding this" case 'text-decoration-line':
style.textDecoration =
ExpressionMapping.expressionToTextDecorationLine(
value as List<css.LiteralTerm>);
List<css.LiteralTerm?>? textDecorationList =
value.whereType<css.LiteralTerm>().toList();
style.textDecoration =
ExpressionMapping.expressionToTextDecorationLine(
textDecorationList);" as well, but same error.
Firstly it drops here

image

Thanks

@windows7lake
Copy link
Contributor Author

Hi, I am alos getting this error, type 'List' is not a subtype of type 'List' in type cast I tried by adding this" case 'text-decoration-line': style.textDecoration = ExpressionMapping.expressionToTextDecorationLine( value as List<css.LiteralTerm>); List<css.LiteralTerm?>? textDecorationList = value.whereType<css.LiteralTerm>().toList(); style.textDecoration = ExpressionMapping.expressionToTextDecorationLine( textDecorationList);" as well, but same error. Firstly it drops here

image

Thanks

pls create a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@erickok erickok erickok approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windows7lake @MuhammadSufyanMalik @erickok