Support maxlines #596
Support maxlines #596
Conversation
|
We want to support this feature but it is not immediately intuitive how |
|
Agreed with @tneotia though I have to say supporting maxLines on a style (and for simplistic use-cases therefor supporting maxLines entirely) is quite unobtrusive and effective. I tend to approve the solution for these reasons. |
|
@erickok if you want to do something like this then what do you say about adding selectable text? Technically it has the same limitations as this feature - e.g. Flutter cannot handle selectable image/audio/video, tables, etc. |
|
Selectable text is also desirable. Both are the proposed solution in the pr is good for me, as it doesn't claim to limit the output to some number of lines, but directly as text style. |
|
I haven't tested this yet, which is the only reason I didn't yet merge. |
lib/style.dart
Outdated
| /// | ||
| /// | ||
| /// | ||
| int? maxLine; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Agreed, this should be named maxLines.
example/lib/main.dart
Outdated
| Html( | ||
| data: htmlDataLines, | ||
| style: { | ||
| 'html': Style(maxLine: 1, textOverflow: TextOverflow.ellipsis), | ||
| }, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh yes the example code here isn't the best to show of this feature. But I like the implementation itself. @nguyenxdat could you follow @tneotia 's suggestion and update the example app?
example/lib/main.dart
Outdated
| body: SingleChildScrollView( | ||
| child: Html( | ||
| data: htmlData, | ||
| style: { | ||
| "table": Style( | ||
| backgroundColor: Color.fromARGB(0x50, 0xee, 0xee, 0xee), | ||
| ), | ||
| "tr": Style( | ||
| border: Border(bottom: BorderSide(color: Colors.grey)), | ||
| ), | ||
| "th": Style( | ||
| padding: EdgeInsets.all(6), | ||
| backgroundColor: Colors.grey, | ||
| child: Column( | ||
| children: [ | ||
| Html( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
No description provided.