Skip to content

Conversation

erickok
Copy link
Contributor

@erickok erickok commented Apr 1, 2021

No description provided.

@erickok
Copy link
Contributor Author

erickok commented Apr 2, 2021

Hey @ryan-berger 👋 Time to release 2.0.0?

@ryan-berger
Copy link
Contributor

@erickok Let's get anchor tags in this release, and then we can get this merged

@erickok
Copy link
Contributor Author

erickok commented Apr 23, 2021

@ryan-berger any decision?

Copy link
Contributor

@IchordeDionysos IchordeDionysos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now possible to use the lastest version of flutter_svg 👍
We did publish an update to flutter_math_fork today.

pubspec.yaml Outdated
@@ -29,10 +29,10 @@ dependencies:
chewie_audio: ^1.2.0

# Plugins for rendering the <svg> tag.
flutter_svg: ^0.21.0-nullsafety.0
flutter_svg: ^0.21.0+1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flutter_svg: ^0.21.0+1
flutter_svg: ^0.22.0

Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com>
@erickok
Copy link
Contributor Author

erickok commented Apr 29, 2021

I have published 2.0.0-nullsafety.1 so our users can benefit from all the fixes and updates, in the meantime.

@ryan-berger
Copy link
Contributor

@ryan-berger any decision?

Sorry, finals have been very wild.

Let's move forward without the link feature. I would like to mess around with a GlobalKey a bit before we roll the link feature.

TLDR; Lets continue with 2.0.0 without links

@tneotia
Copy link
Contributor

tneotia commented May 9, 2021

Let's move forward without the link feature. I would like to mess around with a GlobalKey a bit before we roll the link feature.

TLDR; Lets continue with 2.0.0 without links

Links have already been merged so you'd probably need to revert that somehow if you want to publish without that feature

@ryan-berger
Copy link
Contributor

@tneotia Ooops, okay. No problem. The big thing to make sure it really works well and doesn't consumer lots of resources will be switching over to a stateful widget. I think for now that it is fine

@erickok
Copy link
Contributor Author

erickok commented May 10, 2021

So we release 2.0.0? We really need a 'stable' (non-preview) release with nullability support.

@ryan-berger
Copy link
Contributor

@erickok Yup! Sorry, got lost responding to a discussion. Let me approve this

@erickok erickok merged commit 6cc6c37 into Sub6Resources:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants