-
-
Notifications
You must be signed in to change notification settings - Fork 914
Fix audio/video not disposing when going to a different screen #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audio/video not disposing when going to a different screen #622
Conversation
…into bugfix/audio-video-disposing � Conflicts: � README.md � lib/flutter_html.dart � lib/html_parser.dart
Hi @tneotia, when do you think this PR will be merged in the master branch? |
I think we should clean up any lingering listeners ourselves, one we go the statefull widget way. That should be sufficient, no? |
I agree, but I think this might be a good interim solution until we fully decide to go that route and implement it. |
We still need to fix this but I was hoping to do that after modularization. |
…into bugfix/audio-video-disposing � Conflicts: � lib/html_parser.dart � lib/src/utils.dart
…e automatically, expose controllers to users in a proper API)
@erickok I just overhauled this PR a bit:
|
@tneotia This is probably the first thing we need to merge now. Can you fix the conflict? than I will approve and merge everything. |
…into bugfix/audio-video-disposing � Conflicts: � lib/flutter_html.dart � lib/src/replaced_element.dart � lib/src/styled_element.dart
@erickok done :) |
@tneotia Can you merge master into this? After that I will make an intermediate release 3.0.0-alpha (or with a better name). And after that we can mere in modularization PR. |
…disposing # Conflicts: # example/pubspec.yaml # lib/flutter_html.dart # lib/html_parser.dart
@erickok done. |
fixes #610, fixes #752, fixes #908
I can't reproduce the issue so it needs testing.
Edit: According to @mvn-hainguyen-dn this solution works.