Skip to content

Conversation

tneotia
Copy link
Contributor

@tneotia tneotia commented Apr 13, 2021

fixes #610, fixes #752, fixes #908

I can't reproduce the issue so it needs testing.

Edit: According to @mvn-hainguyen-dn this solution works.

tneotia added 2 commits April 13, 2021 09:39
…into bugfix/audio-video-disposing

� Conflicts:
�	README.md
�	lib/flutter_html.dart
�	lib/html_parser.dart
@yucomds
Copy link

yucomds commented May 6, 2021

Hi @tneotia, when do you think this PR will be merged in the master branch?

@tneotia
Copy link
Contributor Author

tneotia commented May 6, 2021

@yucomds I don't know... @erickok reviews the PRs but he's a bit busy right now so when he's available then it will be reviewed and merged.

If you really need this then you can always use a git dependency pointing to my fork of flutter_html with this branch.

@erickok
Copy link
Contributor

erickok commented May 11, 2021

I think we should clean up any lingering listeners ourselves, one we go the statefull widget way. That should be sufficient, no?

@tneotia
Copy link
Contributor Author

tneotia commented May 11, 2021

I agree, but I think this might be a good interim solution until we fully decide to go that route and implement it.

@erickok
Copy link
Contributor

erickok commented Nov 29, 2021

We still need to fix this but I was hoping to do that after modularization.

…into bugfix/audio-video-disposing

� Conflicts:
�	lib/html_parser.dart
�	lib/src/utils.dart
…e automatically, expose controllers to users in a proper API)
@tneotia
Copy link
Contributor Author

tneotia commented Nov 30, 2021

@erickok I just overhauled this PR a bit:

  1. Html is now a StatefulWidget so we can dispose everything internally
  2. I added a disposeAll method in case someone would need to dispose all controllers being used by all Html widgets
  3. I added convenience getters for users to get controllers being used by Html widgets so things like How to pause the video? #862 and video标签多视频如何加载,并控制播放,暂停 #908 can be done by users.

@erickok
Copy link
Contributor

erickok commented Dec 10, 2021

@tneotia This is probably the first thing we need to merge now. Can you fix the conflict? than I will approve and merge everything.

…into bugfix/audio-video-disposing

� Conflicts:
�	lib/flutter_html.dart
�	lib/src/replaced_element.dart
�	lib/src/styled_element.dart
@tneotia
Copy link
Contributor Author

tneotia commented Dec 10, 2021

@erickok done :)

@erickok
Copy link
Contributor

erickok commented Dec 16, 2021

@tneotia Can you merge master into this? After that I will make an intermediate release 3.0.0-alpha (or with a better name). And after that we can mere in modularization PR.

…disposing

# Conflicts:
#	example/pubspec.yaml
#	lib/flutter_html.dart
#	lib/html_parser.dart
@tneotia
Copy link
Contributor Author

tneotia commented Dec 16, 2021

@erickok done.

@erickok erickok merged commit db41f46 into Sub6Resources:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

video标签多视频如何加载,并控制播放,暂停 Video player, audio track doesn't stop[BUG] Can't stop audio when i move to next screen
3 participants