Skip to content

Add support for more list style types & detect list style type from inline style #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2021
Merged

Add support for more list style types & detect list style type from inline style #654

merged 2 commits into from
May 27, 2021

Conversation

tneotia
Copy link
Contributor

@tneotia tneotia commented May 1, 2021 •
edited
Loading

Adds lower/upper roman, latin, and alpha, along with circle/square list style types.

Adds support for getting list style type from inline CSS when present.

Lower/upper roman, latin, and alpha support the start attribute.

Fixes #704.

@tneotia
Merge branch 'master' of https://github.com/Sub6Resources/flutter_html …
0a4df74 
…into feature/list-style-type

� Conflicts:
�	lib/src/css_parser.dart
@tneotia tneotia mentioned this pull request May 12, 2021
Merged
@tneotia tneotia mentioned this pull request May 26, 2021
Closed
@erickok erickok merged commit 99c7df4 into Sub6Resources:master May 27, 2021
@nishantr4p
Copy link

We should add NONE also as supported type :(
list-style-type: none;

@tneotia tneotia deleted the feature/list-style-type branch December 14, 2021 11:27
@tneotia
Copy link
Contributor Author

tneotia commented Dec 14, 2021

That is there within the package already as well

@nishantr4p
Copy link

nishantr4p commented Dec 14, 2021 •
edited
Loading

Then I need to debug why its not working.. Thanks will check

<ul style='list-style-type:none; list-style: none;'>
<li></li>
</ul>

@tneotia
Copy link
Contributor Author

tneotia commented Dec 14, 2021

Ah, actually I am wrong, we don't support getting none list-style from CSS. You can manually set that inside customRender though. I will make an issue to add this functionality.

@nishantr4p
Copy link

nishantr4p commented Dec 14, 2021 •
edited
Loading

Ah, actually I am wrong, we don't support getting none list-style from CSS. You can manually set that inside customRender though. I will make an issue to add this functionality.

Thanks .. take your time.. I did a work around using <p> with image. if the property is supported it can be controlled from server and make this library more powerful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickok erickok erickok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] list-style-type not working
3 participants
@tneotia @nishantr4p @erickok