change DOM Document to Element for more flexible #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is interesting but also very breaking for people using the fromDom constructor. Id be interested to hear what @erickok has to say on this one. |
|
@tneotia Yes, i do agree. I think we can add another constructor like |
|
I think its a good idea to have the extra constructor which accept an |
|
@andy1xx8 did you plan on updating this PR to add a |
|
@erickok yes i will update this in 1 - 2 days. |
|
@erickok I jave just add a new constructor |
erickok
approved these changes
Jan 14, 2022
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package actually uses and manipulates DOM Element only. But it requires DOM Document as its constructor ( this is unnecessary)
For now, If they have a DOM Element called
elementand I want to use this library, I have to create a new DOM Document. And this is quite complex and adds more boilerplate code.In fact, it's more flexible for the users to pass a DOM element instead of DOM Document.
- If they have a DOM Document call
doc, they can usedoc.documentElement.- If they have. a DOM Element called
element, they can useelementdirectly.