Skip to content

Ignore unsupported custom style selectors #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2021
Merged

Ignore unsupported custom style selectors #857

merged 1 commit into from
Oct 7, 2021

Conversation

zbarbuto
Copy link
Contributor

@zbarbuto zbarbuto commented Oct 6, 2021

Pretty much the same as #779 except also applies to custom styles as well.

Useful as you may, for example, want to load some remote .css file that is not in the HTML <link> tags and then apply the styles using Styles.fromCss(css) but not have it crash from e.g. :hover pseudo-selectors.

erickok
erickok approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for the contribution.

@erickok erickok merged commit 5ec8547 into Sub6Resources:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@erickok erickok erickok approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zbarbuto @erickok