Skip to content

fixed confusing documentation #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2021
Merged

fixed confusing documentation #863

merged 1 commit into from
Oct 15, 2021

Conversation

Carlit0
Copy link
Contributor

@Carlit0 Carlit0 commented Oct 12, 2021

Great package!

This is a documentation quick fix :)

@erickok
Copy link
Contributor

erickok commented Oct 13, 2021

I agree the documentation here is confusing. It is even so confusing that it is wrong (and so is your fix). The tagsList is the list of elements that are rendered, with the exception of the empty list which means the default (full list of supprted tags) is used. So yes, this needs a fix. Happy to accept a PR with the proper wording!

@Carlit0
Copy link
Contributor Author

Carlit0 commented Oct 13, 2021

I agree the documentation here is confusing. It is even so confusing that it is wrong (and so is your fix). The tagsList is the list of elements that are rendered, with the exception of the empty list which means the default (full list of supprted tags) is used. So yes, this needs a fix. Happy to accept a PR with the proper wording!

Right you are!
One question, I squashed my commits and had to use push -f. This rewrote the git history. Does that affect the pull request merge?
Silly me! It certainly would have been easier to squash the commits when merging.

erickok
erickok suggested changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge will be fine, just 2 small questions.

@Carlit0 Carlit0 requested a review from erickok October 14, 2021 13:52
@erickok erickok merged commit a3c398b into Sub6Resources:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@erickok erickok erickok approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Carlit0 @erickok