Skip to content

Image properties and onImageTap for the richTextParser, plus some fixes #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 21, 2019
Merged

Image properties and onImageTap for the richTextParser, plus some fixes #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fdaca87
Added dto for image properties
May 17, 2019
7289b18
Added onTap support, ImageProperties and 'alt' element fix
May 17, 2019
e85915a
Added ImageProperties to the Html widget
May 17, 2019
86ccb5c
Removed gaplessPlayback attribute
May 18, 2019
af4ca1d
Changed InkWell to GestureDetector
May 18, 2019
446cb74
Added parser for 'width' and 'height' attributes for img
May 19, 2019
6962f11
Added support for 'width' and 'height' for img element, and showImages
May 19, 2019
6ebc1ce
Merge branch 'master' into master
Sub6Resources May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/flutter_html.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ library flutter_html;

import 'package:flutter/material.dart';
import 'package:flutter_html/html_parser.dart';
import 'image_properties.dart';

class Html extends StatelessWidget {
Html({
Expand All @@ -22,6 +23,9 @@ class Html extends StatelessWidget {
decoration: TextDecoration.underline,
color: Colors.blueAccent,
decorationColor: Colors.blueAccent),
this.imageProperties,
this.onImageTap,
this.showImages = true,
}) : super(key: key);

final String data;
Expand All @@ -35,6 +39,11 @@ class Html extends StatelessWidget {
final ImageErrorListener onImageError;
final TextStyle linkStyle;

/// Properties for the Image widget that gets rendered by the rich text parser
final ImageProperties imageProperties;
final OnImageTap onImageTap;
final bool showImages;

/// Either return a custom widget for specific node types or return null to
/// fallback to the default rendering.
final CustomRender customRender;
Expand All @@ -61,6 +70,9 @@ class Html extends StatelessWidget {
html: data,
onImageError: onImageError,
linkStyle: linkStyle,
imageProperties: imageProperties,
onImageTap: onImageTap,
showImages: showImages,
)
: HtmlOldParser(
width: width,
Expand All @@ -71,6 +83,7 @@ class Html extends StatelessWidget {
blockSpacing: blockSpacing,
onImageError: onImageError,
linkStyle: linkStyle,
showImages: showImages,
),
),
);
Expand Down
Loading