Skip to content

Conversation

tneotia
Copy link
Contributor

@tneotia tneotia commented Jan 12, 2022

Fixes #976, #970, #969, #968, #959

@tneotia tneotia linked an issue Jan 12, 2022 that may be closed by this pull request
Copy link
Contributor

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes 👍

if (child is EmptyContentElement || child is EmptyLayoutElement) {
toRemove.add(child);
} else if (child is TextContentElement
&& (tree.name == "body" || tree.name == "ul")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is getting s complex... I am sure at one point we need to rewrite this 'node cleanup' altogether.

@erickok erickok merged commit ed48ee8 into master Jan 14, 2022
@Sub6Resources Sub6Resources deleted the bugfix/various-fixes branch June 10, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants