[TASK] Reset GeneralUtility::$container in UnitTestCase::tearDown()
#673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be possible that unit tests sets dependency injection container calling `GeneralUtility::setContainer()` to provide service instances or mocked service instances specific bound to that test, keeping a dirty state for following unit tests. Executing unit tests in other orders, only as a subset or for example randomized can reveal these pullation and eventualy wrong expectation for other tests. [1] This change adds a automatic cleanup to the tearDown for unit tests ensuring a clean state, because there isn't a easy way to reset that within tests without using native php reflection API. So do it in a general place. It may be possible to let the specific test setting such a container intance to fail with the recommendation to refactor the test into a functional test, but is left out for now. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/88839 Releases: main, 8, 7
GeneraulUtility::$container in UnitTestCase::tearDown()GeneralUtility::$container in UnitTestCase::tearDown()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be possible that unit tests sets dependency injection
container calling
GeneralUtility::setContainer()to provideservice instances or mocked service instances specific bound
to that test, keeping a dirty state for following unit tests.
Executing unit tests in other orders, only as a subset or for
example randomized can reveal these pullation and eventualy
wrong expectation for other tests. [1]
This change adds a automatic cleanup to the tearDown for
unit tests ensuring a clean state, because there isn't a
easy way to reset that within tests without using native
php reflection API. So do it in a general place.
It may be possible to let the specific test setting such
a container intance to fail with the recommendation to
refactor the test into a functional test, but is left out
for now.
[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/88839
Releases: main, 8, 7