Skip to content

Added strlen function #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2020
Merged

Added strlen function #606

merged 4 commits into from
Sep 23, 2020

Conversation

realDuYuanChao
Copy link
Member

@realDuYuanChao realDuYuanChao commented Sep 23, 2020 •
edited by gitpod-io bot
Loading

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@realDuYuanChao
Copy link
Member Author

I created strings folder in this repository and implemented strlen algorithms.

@realDuYuanChao
Copy link
Member Author

realDuYuanChao commented Sep 23, 2020 •
edited
Loading

@Panquesito7 Can you please review.

@Panquesito7
Copy link
Member

Are these two files real algorithms?

@realDuYuanChao
Copy link
Member Author

Yes. I think so. https://en.m.wikipedia.org/wiki/Algorithm

@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 23, 2020
Panquesito7
Panquesito7 approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work. 👍 😄

@realDuYuanChao
Copy link
Member Author

For education. We need this algorithm.

@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Sep 23, 2020
realDuYuanChao and others added 2 commits September 24, 2020 01:54
@realDuYuanChao @Panquesito7
Update strings/strlen.c
edb6375 
Co-authored-by: David Leal <halfpacho@gmail.com>
@realDuYuanChao @Panquesito7
Update strings/strlen_recursion.c
b9bab8d 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 merged commit 598630c into TheAlgorithms:master Sep 23, 2020
kvedala added a commit that referenced this pull request Sep 23, 2020
@kvedala
Revert "Added strlen function (#606)"
64eaaa1 
This reverts commit 598630c.
@kvedala kvedala mentioned this pull request Sep 23, 2020
Merged
kvedala added a commit that referenced this pull request Sep 23, 2020
@kvedala
Revert "Added strlen function (#606)" (#607)
526c898 
This reverts commit 598630c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@kvedala kvedala Awaiting requested review from kvedala

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realDuYuanChao @Panquesito7