Skip to content

Conversation

ashish5kmax
Copy link
Contributor

@ashish5kmax ashish5kmax commented Oct 5, 2024

  • I would like to help you by adding sliding window algorithms one of them is a famous question asked in interviews that is "Longest Substring Without Repeating Characters".

  • I hope this helps the community.

  • Thank you.

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

* I would like to contribute for sliding window algorithm and this one is one of the famous problem that is asked in interviews.

* Thank you!!.
…to sliding-window/Longest_Substring_Without_Repeating_Characters.cpp

* This is my contribution towards the sliding window algorithm/s and this is one of the famous problems.

* Thank you.
* I would like to contribute towards the sliding window algorithm in which this is one of the famous problem asked in interviews.

* Thank you.
* Updated certain changes in documentation, this is my contribution towards sliding window algorithm this is one of the famous interview problem.

* Thank you.
* Well documented and tested code for sliding window algorithm.

* Thank you.
@realstealthninja
Copy link
Collaborator

Unfortunately we dont currently accept leetcode solutions see #2450
the directory you created is unnecessary and does not have a CMakeLists.txt file.
will be closing soon! Thank you for your contribution.

@realstealthninja realstealthninja added not-an-algorithm pull request is not an algorithm requested changes changes have been requested and removed not-an-algorithm pull request is not an algorithm labels Oct 5, 2024
@ashish5kmax
Copy link
Contributor Author

what if I put these under the other section will that be fine

@realstealthninja
Copy link
Collaborator

realstealthninja commented Oct 5, 2024

what if I put these under the other section will that be fine

yes but use a proper class instead of the solution one you've used
please read the contributing.md file before doing so.
thank you for the contribtuion

…to Longest_Substring_Without_Repeating_Characters.cpp

* So,I did a small change I added the problem into the others section I think this works fine I guess.

* I would be glad if this can be tagged as hackoctoberfest 

* Thank you.
…to longest_substring_without_repeating_characters.cpp

* I hope I have done the required changes.
* Added specific edge cases and tests as void tests() and followed the guidelines.
* I hope I have made the necessary changes required.

* If there are any changes to make I can do that.

* Thank you.
@ashish5kmax
Copy link
Contributor Author

  • any update on my PR.

* I have done the required changes for the include part.

* Thank you.
@ashish5kmax
Copy link
Contributor Author

  • If the code get's merged can you label this as hackoctoberfest.
  • Thank you.

@ashish5kmax
Copy link
Contributor Author

ashish5kmax commented Oct 8, 2024

any updates.

@ashish5kmax
Copy link
Contributor Author

  • Haven't got any review, past 2 days is this code ok or I have to fix something.

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for this contribution.

@realstealthninja realstealthninja added approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed requested changes changes have been requested labels Oct 9, 2024
@ashish5kmax
Copy link
Contributor Author

ashish5kmax commented Oct 9, 2024

Thank you.
And waiting for more such contributions in future.
Happy to help!!.

@realstealthninja realstealthninja merged commit 5eff2b9 into TheAlgorithms:master Oct 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants