Skip to content

Add A006879 Number of Primes by Number of Digits sequence #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2022
Merged

Add A006879 Number of Primes by Number of Digits sequence #287

merged 3 commits into from
Feb 15, 2022

Conversation

OleksiiHe
Copy link
Contributor

Adding A006879 Number of Primes by Number of Digits sequence
OEIS
Wikipedia

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@OleksiiHe OleksiiHe requested a review from siriak as a code owner February 9, 2022 00:09
@codecov
Copy link

codecov bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Merging #287 (65058a6) into master (bcd50b8) will increase coverage by 0.00%.
The diff coverage is 95.34%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files         163      167    +4     
  Lines        7698     7741   +43     
=======================================
+ Hits         7317     7358   +41     
- Misses        381      383    +2
Impacted Files Coverage Δ
...ms/Sequences/NumberOfPrimesByPowersOf10Sequence.cs 92.85% <92.85%> (ø)
...equences/NumberOfPrimesByNumberOfDigitsSequence.cs 93.33% <93.33%> (ø)
Algorithms/Sequences/PowersOf10Sequence.cs 100.00% <100.00%> (ø)
Algorithms/Sequences/PowersOf2Sequence.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681ca77...65058a6. Read the comment docs.

siriak
siriak previously approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit 4748ad0 into TheAlgorithms:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OleksiiHe @siriak