Skip to content

Added A006577 sequence: number of '3n+1' steps to reach 1 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2022
Merged

Added A006577 sequence: number of '3n+1' steps to reach 1 #302

merged 3 commits into from
Apr 27, 2022

Conversation

vicent-baeza
Copy link
Contributor

Added sequence A006577, the number of halving and tripling steps to reach 1 in the '3n+1' problem.
For more information about the problem and the sequence, visit https://en.wikipedia.org/wiki/Collatz_conjecture.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@vicent-baeza vicent-baeza requested a review from siriak as a code owner April 25, 2022 23:17
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #302 (ae0292d) into master (906dfaa) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   95.11%   95.04%   -0.07%     
==========================================
  Files         178      179       +1     
  Lines        7878     7898      +20     
==========================================
+ Hits         7493     7507      +14     
- Misses        385      391       +6
Impacted Files Coverage Δ
Algorithms/Sequences/ThreeNPlusOneStepsSequence.cs 100.00% <100.00%> (ø)
Algorithms/Numeric/MillerRabinPrimalityChecker.cs 81.81% <0.00%> (-18.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da10a33...ae0292d. Read the comment docs.

siriak
siriak approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit cba779c into TheAlgorithms:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicent-baeza @siriak