Run golangci-lint on the entire codebase #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgurwara99
approved these changes
Feb 18, 2021
tjgurwara99
reviewed
Feb 18, 2021
.github/workflows/golangci-lint.yml
Outdated
| # only-new-issues: true # Let's focus on this PR first | ||
| - run: echo "/home/runner/golangci-lint-1.31.0-linux-amd64" >> $GITHUB_PATH | ||
| version: v2.4 | ||
| - run: echo "/home/runner/golangci-lint-2.4.0-linux-amd64" >> $GITHUB_PATH | ||
| - run: go version ; golangci-lint --version # Fix the following and remove || true |
There was a problem hiding this comment.
Suggested change
| - run: go version ; golangci-lint --version # Fix the following and remove || true | |
| - run: echo "/home/runner/golangci-lint-1.31.0-linux-amd64" >> $GITHUB_PATH | |
| - run: go version ; golangci-lint --version # Fix the following and remove || true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tjgurwara99 @vedantmamgain Does line 22 properly run the linter on all .go files in the repo?
Can/should line 23's errors be safely ignored?