Skip to content

Incorrect file extension and other improvements #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shivamshrey opened this issue Oct 23, 2021 · 0 comments
Closed

Incorrect file extension and other improvements #2716

shivamshrey opened this issue Oct 23, 2021 · 0 comments

Comments

@shivamshrey
Copy link
Contributor

Describe the bug

  • File name is incorrect.
  • Algorithm can be improved.
  • Lots of typos and syntax errors.
  • Inconsistent formatting throughout
  • Incorrect file extension
  • File naming convention is not followed.
  • Missing URL for algorithm explanation.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'detect_and_create_loop.jav'
  2. Try running the file

Expected behavior

  • The file extension should be .java and not .jav.
  • The file name and class name should be proper.
  • The code should be readable.
  • No syntax errors or typos.

Screenshots

Device Specification

Additional context
@shivamshrey shivamshrey changed the title Improvements required in #2346 Incorrect file extension and other improvements Oct 23, 2021
shivamshrey added a commit to shivamshrey/Java that referenced this issue Oct 23, 2021
@shivamshrey
Add algorithm explanation URLs TheAlgorithms#2346 (Fixes TheAlgorithm…
c9059d7 
…s#2716)
@shivamshrey shivamshrey mentioned this issue Oct 24, 2021
Merged
12 tasks
@siriak siriak closed this as completed in 9b90628 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shivamshrey