Skip to content

Adding Order Agnostic Binary Search #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThisIsNishanth opened this issue Dec 7, 2022 · 7 comments
Closed

Adding Order Agnostic Binary Search #3790

ThisIsNishanth opened this issue Dec 7, 2022 · 7 comments

Comments

@ThisIsNishanth
Copy link
Contributor

ThisIsNishanth commented Dec 7, 2022 •
edited
Loading

What would you like to Propose?

Order Agnostic Binary Search Algorithm on 1-D Arrays.

Issue details

Order Agnostic Binary Search algorithm is used when we do not know whether the given array is descending or ascending.

Example: [5,4,3,2,1]
I can write clean code to find out whether the array is ascending or descending and apply Binary Search on it.

Please assign this to me as I have worked on this problem before.

Additional Information

No response
@ThisIsNishanth
Copy link
Contributor Author

ThisIsNishanth commented Dec 7, 2022 •
edited
Loading

Hey, I have created a pull request for this idea along with the code.

@ThisIsNishanth ThisIsNishanth changed the title Adding Order Agnostic Binary Search(Clean & Readable Code) Adding Order Agnostic Binary Search Dec 7, 2022
@siriak
Copy link
Member

siriak commented Dec 24, 2022

Which PR is that?

@shahabrar7746
Copy link

shahabrar7746 commented Jan 16, 2023 •
edited
Loading

hey @siriak i have raised a PR for this issue. #3858

@dineshlalam15
Copy link

!assign

@SunilKumar-K
Copy link
Contributor

@siriak I have raised a pr on this issue .#3882 and added clean code and test cases also.

@Swarga-codes
Copy link
Contributor

Is this issue open? If so, can I work on it?

@siriak
Copy link
Member

siriak commented Mar 8, 2023

It's done

@siriak siriak closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@siriak @Swarga-codes @shahabrar7746 @dineshlalam15 @ThisIsNishanth @SunilKumar-K