Skip to content

added agnosticBinarySearch algorithm and Testcases for ascending and descending order #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 23, 2023
Merged

added agnosticBinarySearch algorithm and Testcases for ascending and descending order #3882

merged 9 commits into from
Feb 23, 2023

Conversation

SunilKumar-K
Copy link
Contributor

@SunilKumar-K SunilKumar-K commented Feb 17, 2023 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@SunilKumar-K SunilKumar-K mentioned this pull request Feb 17, 2023
Closed
siriak
siriak requested changes Feb 19, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix formatting and name variables descriptively

@SunilKumar-K
Copy link
Contributor Author

@siriak can you check this once is there any modifications let me know !

@SunilKumar-K SunilKumar-K requested a review from siriak February 20, 2023 13:04
siriak
siriak reviewed Feb 21, 2023
View reviewed changes
siriak
siriak requested changes Feb 21, 2023
View reviewed changes
@SunilKumar-K SunilKumar-K requested a review from siriak February 21, 2023 17:20
@siriak siriak enabled auto-merge (squash) February 23, 2023 17:18
siriak
siriak approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 6b9eb1b into TheAlgorithms:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunilKumar-K @siriak