Skip to content

[FEATURE REQUEST] DFS and BFS search algorithms are lack of effective tests and Node class should be decoupled from DFS #4229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snirt opened this issue Jul 6, 2023 · 2 comments · Fixed by #4230
Closed

[FEATURE REQUEST] DFS and BFS search algorithms are lack of effective tests and Node class should be decoupled from DFS #4229

snirt opened this issue Jul 6, 2023 · 2 comments · Fixed by #4230
Labels
enhancement stale

Comments

@snirt
Copy link
Contributor

snirt commented Jul 6, 2023

What would you like to Propose?

  • Write DFS and BFS search algorithms effective tests.
  • Write a new Node class in structures - its should be decoupled from the DFS class.
  • Some code refactoring.
  • Support of multiple data types

Issue details

BreadthFirstSearch.java

  • add algorithm tests

  • refactor
    DepthFirstSearch.java

  • write a new test file

  • refactor - mention that this is a recursive solution (in the future add an iterative solution as well)

Additional Information

No response
@snirt snirt mentioned this issue Jul 6, 2023
Merged
5 tasks
@abhisheksharma010
Copy link

Hello, I would like to work on this, can it be assigned to me

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 10, 2023
siriak pushed a commit that referenced this issue Aug 13, 2023
@snirt
Make DFS and BFS search algorithms generic (fixes #4229) (#4230)
1884857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DFS and BFS search algorithms - Resolve #4229 snirt/Java-algorithms
2 participants
@snirt @abhisheksharma010