Skip to content

[BUG] Tests of Isomorphic #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vil02 opened this issue Jun 3, 2025 · 5 comments · Fixed by #6259
Closed

[BUG] Tests of Isomorphic #6258

vil02 opened this issue Jun 3, 2025 · 5 comments · Fixed by #6259
Assignees
@raveendra11
Labels
bug good first issue

Comments

@vil02
Copy link
Member

vil02 commented Jun 3, 2025 •
edited
Loading

Description

Note that the tests of Isomorphic are not executed.

Steps to reproduce

  1. run mvn test
  2. the output contains:
(1) [WARNING] @Test method 'public static void com.thealgorithms.strings.IsomorphicTest.main(java.lang.String[])' must not be static. It will not be executed.
    Source: MethodSource [className = 'com.thealgorithms.strings.IsomorphicTest', methodName = 'main', methodParameterTypes = '[Ljava.lang.String;']
            at com.thealgorithms.strings.IsomorphicTest.main(SourceFile:0)

Excepted behavior

Tests should be executed.

Screenshots

No response

Additional context

Update the existing test file. I suggest to express the tests as parametrized (search for @ParameterizedTest to see examples, e.g. BandwidthAllocationTest).
@raveendra11
Copy link
Contributor

Hi @vil02 I want to give it a try, could you assign to me?

@vil02
Copy link
Member Author

vil02 commented Jun 3, 2025 •
edited
Loading

@raveendra11 go ahead!

raveendra11 added a commit to raveendra11/Java that referenced this issue Jun 3, 2025
@raveendra11
[TheAlgorithms#6258][BUG] Tests of Isomorphic
ca48862
@Maralsabetian
Copy link

Hello,
I would like to work on it, if it is ok with you.
Kindly assign it to me.

@raveendra11 raveendra11 mentioned this issue Jun 3, 2025
Merged
6 tasks
@vil02
Copy link
Member Author

vil02 commented Jun 3, 2025

@Maralsabetian: @raveendra11 is assigned to this issue and already made a promising pull-request:

@Maralsabetian
Copy link

I see, Thanks.

vil02 added a commit that referenced this issue Jun 3, 2025
@raveendra11 @vil02
tests: properly test Isomorphic (#6259)
e123ca1 
Fixes #6258

---------

Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raveendra11 raveendra11

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: properly test Isomorphic raveendra11/Java
3 participants
@vil02 @raveendra11 @Maralsabetian