Skip to content

Add more algorithms #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnupKumarPanwar opened this issue Sep 28, 2017 · 46 comments · Fixed by #240
Closed

Add more algorithms #96

AnupKumarPanwar opened this issue Sep 28, 2017 · 46 comments · Fixed by #240

Comments

@AnupKumarPanwar
Copy link
Member

This repo has less contributions. Please add more algorithms.

See the structure and README of this repo for reference
https://github.com/TheAlgorithms/Python

@dhinske
Copy link
Contributor

dhinske commented Sep 28, 2017

would you be interested in some Set-implementations or maybe Bag? didnt see it in your repo :)

@dpunosevac
Copy link

I would like to contribute it. I see that you have no shell sort algorithm for Java. I would take that one first. Than later I would continue with few mores, if that is ok.

@mpokryva
Copy link
Contributor

Would you be interested in a level-order tree traversal?

@dynamitechetan
Copy link
Member

Thanks. @mpokryva

@mpokryva
Copy link
Contributor

mpokryva commented Sep 28, 2017

Ok, I will take that then. Or, if you want, @dpunosevac , you can do that, and I can do some bit algorithms, as I don't see any of those.

@dpunosevac
Copy link

@mpokryva I mistakenly thought you were talking to me. And not asking for yourself. Anyway, you can grab that one, and I hope that @dynamitechetan needs shellsort, so I do that one.

@mpokryva
Copy link
Contributor

Ok, sounds good! Sorry for the misunderstanding :)

@varunu28
Copy link
Contributor

@dynamitechetan @AnupKumarPanwar Would be continue to add more algorithms to this as a part of hacktoberfest
PRs would be maily in Data Structures and other domain

@rei2hu
Copy link
Contributor

rei2hu commented Sep 28, 2017

Please look over pull requests before merging because I noticed the most recent one won't even compile properly and I'm assuming that a lot of people will make PRs soon because of Hacktoberfest (myself included). For example, in PR #101 there are many errors.

Can't compile because there is no type for len_a and len_b
Can't compile because calculate_distance is a non-static method
One of the loops will go on forever because it's declared as for(int j = 0; i < len_b; j++) and i is not getting updated within the loop.

@varunu28
Copy link
Contributor

@rei2hu @dynamitechetan @AnupKumarPanwar
Also the PRs should be monitored correctly to check for coding style and if an addition to the repo is actually an algorithm or just a solution of an interview question. The long term goal should be to make this repo as a one stop solution for Java algorithms rather than a repository with bunch of random interview problems.

@AnupKumarPanwar
Copy link
Member Author

@dynamitechetan @varunu28 @rei2hu
I think we should create a repo that contains simple English explanation of the algorithms with example and a link to their implementation in different programming languages.

@praveenkannan
Copy link

praveenkannan commented Sep 29, 2017

@AnupKumarPanwar I am relatively late here so I thought I directly ask you. Whats next in your priority list. i ll address it. I love writing algorithms.

@AnupKumarPanwar
Copy link
Member Author

@praveenkannan I would like you to contribute on
https://github.com/TheAlgorithms/Algorithms-Explainations

@praveenkannan
Copy link

@AnupKumarPanwar assign that to me. I am starting to work on it now.

@Alastifer
Copy link

@AnupKumarPanwar can I write dijkstra algo on Java?

@TheFern2
Copy link

TheFern2 commented Oct 1, 2017

Wouldn't it be easier to keep track of the algorithms that are missing? Some sort of list on the repo maybe.

manmeet-22 added a commit to manmeet-22/Java that referenced this issue Oct 1, 2017
Note- Give input in the form like "1 21 + 45 13 + *"
TheAlgorithms#96
@MichGedd
Copy link

MichGedd commented Oct 1, 2017

Would I be able to write A* Algorithm? I created a version in Processing

@TheFern2
Copy link

TheFern2 commented Oct 2, 2017

I've looked at the python repo, and I will be doing a bunch of the cypher algorithms.

wick3dshadow added a commit to wick3dshadow/Java that referenced this issue Oct 21, 2017
wick3dshadow added a commit to wick3dshadow/Java that referenced this issue Oct 21, 2017
@akshay326
Copy link
Contributor

separated main and generatePassword functions #218

dynamitechetan added a commit that referenced this issue Oct 25, 2017
Added and Implemented Counting sort with Java. #96.
@PAPERPANKS
Copy link
Contributor

@AnupKumarPanwar reopen this issue i have added a new example

YJDave added a commit to YJDave/Java that referenced this issue Oct 25, 2017
YJDave added a commit to YJDave/Java that referenced this issue Oct 25, 2017
@YJDave
Copy link

YJDave commented Oct 25, 2017

@AnupKumarPanwar Add algorithm for Bucket Sort. Let me know if any changes are required :)

Daviddager added a commit to Daviddager/Java that referenced this issue Oct 26, 2017
t0rr3sp3dr0 added a commit to t0rr3sp3dr0/Java that referenced this issue Oct 26, 2017
@italo-batista
Copy link

I have just opened a pull request in which I add the Floyd Warshall graph algorithm to find shortest paths between every pair of vertices. If you please review me.. (:

@italo-batista
Copy link

I also opened a pull request to add the sorting algorithm QuickSortMedianOfThree. 😁

@zhexuany
Copy link

add a algo for coin change https://github.com/TheAlgorithms/Java/pulls

@italo-batista
Copy link

Pull Request to add Bellman-Ford graph algorithm to find shortest path from one vertex to all. 😃

AnupKumarPanwar added a commit that referenced this issue Nov 9, 2017
Simple Heap Sorting Technique Using Java #96
@Febaug
Copy link
Contributor

Febaug commented Nov 12, 2017

Hey, a friend of mine and I would write the Hopcroft-Karp algorithm with the amount of maximal cardinal matchings as output and - if we're able to implement it - extend it later to give out the exact matchings.

@Phil-Schmidt
Copy link
Contributor

Hi there, user Febaug has tipped me off about this project and I'd like to contribute as well. I've seen that you have a subdirectory for crypto algorithms, but you're still missing an implementation of the Advanced Encryption Standard. I'd love to build that for you unless you see a problem with that.

@YooSeonjae
Copy link
Contributor

YooSeonjae commented Dec 17, 2017

Add a circular queue or ring wait, a data structure that uses a single fixed-size buffer just like an end-to-end connection
#322

@YooSeonjae
Copy link
Contributor

One of the greedy algorithms, Scheduling to Minimize Lateness
#309

@anthonycampbell
Copy link

Could I add a skiplist implementation?

@RishiPrakash
Copy link

I have added pullRequest , please review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment