Add hexadecimal to binary and hexadecimal to decimal conversions #1328
Conversation
40c192c to
724ff7e
Compare
| package com.conversions; | ||
|
|
||
| public class HexadecimalToBinary { | ||
| /** |
There was a problem hiding this comment.
Your code fails in case of floating point conversion, 'ABC.BC' try doing it for real values also
There was a problem hiding this comment.
Good work but you missed out in the 2nd file.
|
@deadshotsb Okay, thank you for your feedback I will fix it now. |
|
@deadshotsb I have just fixed the requested changes can you check it and give me your feedback? |
| package com.conversions; | ||
|
|
||
| public class HexadecimalToBinary { | ||
| /** |
There was a problem hiding this comment.
Good work but you missed out in the 2nd file.
| * @return decimal number | ||
| */ | ||
| public String hexToDecimal(String hexaStr) { | ||
| String hexaNumbers = "0123456789ABCDEF"; |
There was a problem hiding this comment.
Your code fails in case of "AB.CD"
There was a problem hiding this comment.
because from the point you must multiply for 1/16, the potency start to be negative
There was a problem hiding this comment.
@nippur101
Yes, that's what I did, thank you
|
@deadshotsb you are right sir, I'll do it now! Sorry |
|
@MohamedBechir We are all developers no sir and boss please |
|
@deadshotsb can you explain more what I am supposed to do? A.B => 10.11 or A.B => 10.6875? thank you |
|
A.B = 16^(0)*(10) + 16^(-1) * (11) |
|
@deadshotsb I just fixed it, take a look. Thank you again |
I have noticed that some conversions are missing, so I started by adding the hexadecimal to decimal and the hexadecimal to binary ones, if you approve it I can work on the other ones.
My code converts a hexadecimal number to a decimal one.
NB: I am new to the software engineering community. I did my best and if anything is wrong with my code I can change it anytime, I am eager to learn more.