Issue #84 (merged redundant classes InsertionSortInteger, InsertionSort) #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… been replaced by Generic InsertionSort class)
… fixed. It returns node if it is found otherwise returns null.
|
@ss3681755 Is there any particular reason about why have you overwritten the existing Generic Insertion Sort? |
|
The only reason I overwrote that file is just because to make variables more meaningful so that people can understand them easily. |
|
@ss3681755 I think the existing code is pretty self explanatory along with a proper driver main method which tests the code. I would be closing this PR. Just raise a separate PR for BST. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #84 (Redundant classes InsertionSortInteger, InsertionSort have been replaced by Generic InsertionSort class)