I'm closing this as I've replaced it with #2023 which merges to Development instead and includes unit tests.

would you please remove convolutionFFT.java from this PR, as this file is not related to this PR.

would you please remove convolutionFFT.java from this PR, as this file is not related to this PR.

I could try, but that was the Google Java Formatter that did that, not me.
If I undo it, won't it just format it again?

would you please remove convolutionFFT.java from this PR, as this file is not related to this PR.

I could try, but that was the Google Java Formatter that did that, not me.
If I undo it, won't it just format it again?

it is weird, Fromatter will format only those files which are linked to the PR. If it starts formatting files which are not linked in PR then there are so many files in the repository which are not up to standard, it would have formatted all of them.

Well try to remove this from this PR.

I removed both DIRECTORY.md and ConvolutionFFT.java , however it seems the bot decided to apply the formatting to ConvolutionFFT.java again, and also split up the markdown in the javadocs. 🤔

I removed both DIRECTORY.md and ConvolutionFFT.java , however it seems the bot decided to apply the formatting to ConvolutionFFT.java again, and also split up the markdown in the javadocs. 🤔

How did you removed ConvolutionFFt.java from PR?

How did you removed ConvolutionFFt.java from PR?

I just did git checkout origin/master -- Maths/ConvolutionFFT.java to revert it back to the version in master.

How did you removed ConvolutionFFt.java from PR?

I just did git checkout origin/master -- Maths/ConvolutionFFT.java to revert it back to the version in master.

🤔 try git restore <path to file>

thinking try git restore <path to file>

Tried it, however no changes were made, no files were staged, and git log doesn't return any new commits.
It appears to have done nothing.

Please add a test function to verify the implementation, rest of the code looks good to me.

Just checking, is there a section for unit tests?
This PR already has a main method that should be valid.

public static void main(String args[]) {
  final ColorContrastRatio algorithmImpl = new ColorContrastRatio();

  // Relative Luminance: 0.12215748057375966
  final Color foreground = new Color(23, 103, 154);

  // Relative Luminance: 0.7898468477881603
  final Color background = new Color(226, 229, 248);

  // Contrast Ratio: 4.878363954846178
  final double contrastRatio = algorithmImpl.getContrastRatio(foreground, background);

  System.out.println(contrastRatio);
}

Looking at other classes, this appears to be how they're testing it also.

May I also ask, you requested some javadocs have @brief prepended to them, but I'm unfamiliar with it, and can't see any other uses of it throughout the repository.

Could you explain why you wanted this or what it does?

Please add a test function to verify the implementation, rest of the code looks good to me.

Just checking, is there a section for unit tests?
This PR already has a main method that should be valid.

public static void main(String args[]) {
  final ColorContrastRatio algorithmImpl = new ColorContrastRatio();

  // Relative Luminance: 0.12215748057375966
  final Color foreground = new Color(23, 103, 154);

  // Relative Luminance: 0.7898468477881603
  final Color background = new Color(226, 229, 248);

  // Contrast Ratio: 4.878363954846178
  final double contrastRatio = algorithmImpl.getContrastRatio(foreground, background);

  System.out.println(contrastRatio);
}

Looking at other classes, this appears to be how they're testing it also.

yes, i know it does have a main method. what i want to say is that, create a member function with name tests.

void test() {
      final ColorContrastRatio algorithmImpl = new ColorContrastRatio();
      // test 1
      final Color foreground = new Color(23, 103, 154);
      final Color background = new Color(226, 229, 248);
      final double contrastRatio = algorithmImpl.getContrastRatio(foreground, background);
      assert contrastRation == 4.878363954846178 : "Failed test 1";
      // test 2
      ..............................
      ..............................
      .............................
}
public static void main(String [] args) {
     // call test() here to execute test.
}

May I also ask, you requested some javadocs have @brief prepended to them, but I'm unfamiliar with it, and can't see any other uses of it throughout the repository.

Could you explain why you wanted this or what it does?

Currently this repository is not up to a good standard, I am planing to improve this repository as we did in C++ repository. The reason i am enforcing javadocs style is, with the help of javadocs we can generate documentation for this repository automatically. Other files are not mainted properly, we will be improving them soon.

please have a look here https://thealgorithms.github.io/C-Plus-Plus/ (this is the documentaion of C++ repository algorithms, it is generated automatically using Doxygen)
this is what i am thinking to do with this repo too.

Soon we will be updating the contribution guidelines so that people will follow proper guildelines for each and every PR. Thereby facilitating faster reviews and less burden on Maintainers and Contributors.

yes, i know it does have a main method. what i want to say is that, create a member function with name tests.

Understood, thanks for clarifying, I believe I've done this now.

please have a look here https://thealgorithms.github.io/C-Plus-Plus/ (this is the documentaion of C++ repository algorithms, it is generated automatically using Doxygen)

Ahh I see, I wasn't familiar with Doxygen before now, I've only ever used the vanilla Javadocs. That would explain the markdown and odd tags I've never seen before.

High hopes this is fine now? Don't be afraid to let me know if there are any other issues.