-
Notifications
You must be signed in to change notification settings - Fork 20k
Addition of a few new codes in strings, Misc, Maths and DataStructures/Graphs folders. #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @shellhub, |
@AzadN Sure, would love to review your PR. I stopped reviewing PR as they where not being merged, and instead started to work myself to create a repo sort of this. Also, if your code formatter test are not being passed, try running the following commands in terminal or powershell in folder -
I would start detailed reviewing by today evening, just give me some time. |
Sure. By the way, that code formatter check has suddenly disappeared from the total checks done don't know how :) |
So many files changed. Can you create PR for each file. So it will be easy to review. |
So shall I close this current PR and issue separate PRs for each file added in this PR? It would be nice if the review & merging was possible for this PR itself but I understand the complication and tediousness of doing so. |
Yes. And add documentation to source code. and test using |
@AkMo3 sorry buddy, have to close this PR to issue separate PR per file. Hope you didn't start reviewing already. |
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}
.