Skip to content

Added matrixTranspose.java to misc folder #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 17, 2021
Merged

Added matrixTranspose.java to misc folder #2041

merged 12 commits into from
Sep 17, 2021

Conversation

Rajat-Jain29
Copy link
Contributor

@Rajat-Jain29 Rajat-Jain29 commented Nov 21, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
please write relevant documentaion and remove the .yaml.txt file from the PR

@Rajat-Jain29
Copy link
Contributor Author

Rajat-Jain29 commented Nov 22, 2020 via email

@ayaankhan98
Copy link
Member

ayaankhan98 commented Nov 22, 2020

Sir But problem is that check Code formator is not clear so please provide some solution ao that I can clear

On Sun, 22 Nov, 2020, 10:57 pm Ayaan Khan, @.> wrote: @.* commented on this pull request. ------------------------------ In Misc/matrixTranspose.java <#2041 (comment)>: > @@ -0,0 +1,39 @@ +package math; + +import java.util.*; import only required classes instead of import everything — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2041 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR2RIZRYI2BHDT3QNNCRGT3SRFCYXANCNFSM4T56CUKA .

@Rajat-Jain29 No need to worry about that code formatter seems to be broken. that's not your error
This repo was not under maintainance so somethings need fix, this is one of them

@Rajat-Jain29
Copy link
Contributor Author

Rajat-Jain29 commented Nov 22, 2020 via email

@ayaankhan98
Copy link
Member

please write relevant documentaion

@Rajat-Jain29
Copy link
Contributor Author

Rajat-Jain29 commented Nov 22, 2020 via email

@ayaankhan98
Copy link
Member

Sir can you please explain what is relevant documentation .?? Because sir its my first time of contribution so I don't have any idea about it So please give some idea about documentation please sir

On Sun, 22 Nov, 2020, 11:43 pm Ayaan Khan, @.***> wrote: please write relevant documentaion — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2041 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR2RIZRZLKCKMVHP5Y4OIFTSRFIEFANCNFSM4T56CUKA .

Documentation basically refers to comments which explains your code properly.
please refer here

@Rajat-Jain29
Copy link
Contributor Author

Rajat-Jain29 commented Nov 22, 2020 via email

@Rajat-Jain29
Copy link
Contributor Author

Rajat-Jain29 commented Nov 22, 2020 via email

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@siriak siriak merged commit d8b06a3 into TheAlgorithms:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants