Skip to content

Add Euler method #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add Euler method #2130

wants to merge 5 commits into from

Conversation

algobytewise
Copy link
Contributor

@algobytewise algobytewise commented Mar 9, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algobytewise
Copy link
Contributor Author

I was able to fix the error thrown by the code-formatter-check but I can't get it to pass the prettier-check. Could someone help me out?

ayaankhan98
ayaankhan98 reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, please update the documentation according to Java docs standard.

refer to the documentation of this file in case you need any help regarding documentation.

also add tests

@algobytewise
Copy link
Contributor Author

Thanks for the feedback. I've reformatted the documentation and I've implemented tests to validate that the numerical arguments are in range.

@danielUTM
Copy link

danielUTM commented Mar 15, 2021 •
edited
Loading

I just created another pull request for a separate addition that kept failing on the "Prettier / prettier" check with the same error message you are getting. I fixed the issue by changing branch I was comitting from to be called master and it fixed it, hope this helps you.

@algobytewise algobytewise mentioned this pull request Mar 16, 2021
Merged
12 tasks
@algobytewise
Copy link
Contributor Author

Thank you for this insight! I've tried it and it also solved the problem for me, see #2148 . I'll close this pull request & open an issue.

@algobytewise algobytewise mentioned this pull request Mar 16, 2021
Closed
@algobytewise algobytewise deleted the add-euler-method branch April 26, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algobytewise @danielUTM @ayaankhan98