Additional files similiar to TheAlgorithms/Python #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Guass Legendre algorithm for approximation of PI |
varunu28
suggested changes
Oct 21, 2017
There was a problem hiding this comment.
- Please provide a name for the password_gen.java according to proper naming convention (As PasswordGen)
- Please look for coding convention for password_gen.java (Check for proper spacing and closing brackets)
- nested_brackets is popularly known as the balanced brackets problems and it comes under the stack algorithms umbrella. So please rename it and move it under the stacks folder
|
changes implemented |
varunu28
suggested changes
Oct 23, 2017
separated main and generatePassword function
|
separated main and generatePassword functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding 2 more short programs in reference to issue #96