Skip to content

Add Sort singly linked list #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Sort singly linked list #2507

wants to merge 1 commit into from

Conversation

resilient-maximus
Copy link

Given the head of a linked list, return the list after sorting it in ascending order.
Implemented divide and conquer algorithm for sorting a singly linked list.

References

Sort a Linked List #2450

  • [x ] I have read CONTRIBUTING.md.
  • [ x] This pull request is all my own work -- I have not plagiarized.
  • [ x] I know that pull requests will not be merged if they fail the automated tests.
  • [ x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x] All new Java files are placed inside an existing directory.
  • [ x] All filenames are in all uppercase characters with no spaces or dashes.
  • [ x] All functions and variable names follow Java naming conventions.
  • [ x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Add Sort singly linked list
ef1507d 
Given the head of a linked list, return the list after sorting it in ascending order.
@resilient-maximus
Copy link
Author

@siriak please review the PR

siriak
siriak requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there's a singly linked list already implemented here https://github.com/TheAlgorithms/Java/blob/master/DataStructures/Lists/SinglyLinkedList.java. Please use it instead of creating a new one

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 11, 2021
@github-actions
Copy link

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@github-actions github-actions bot closed this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@resilient-maximus @siriak