Skip to content

Add Bucket Sort Algorithm #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

YJDave
Copy link

@YJDave YJDave commented Oct 25, 2017

Fixes #96

@YJDave
Copy link
Author

YJDave commented Nov 9, 2017

@AnupKumarPanwar please review PR!! and let me know suggestions!

@YJDave YJDave mentioned this pull request Nov 9, 2017
Copy link
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly keep a separate function for the sorting algorithm and use the main method only for testing the algorithm
  • Convert the algorithm to its generic version

@YJDave
Copy link
Author

YJDave commented Nov 9, 2017

@varunu28 I understand your first point. But didn't get second point. Do you want me to convert it into generic in terms of data type or in terms of range of input?

@varunu28
Copy link
Contributor

varunu28 commented Nov 9, 2017

@YJDave Your algorithm should sort the arrays of all data types. Be it string array or an integer array. Please check Insertion Sort for reference

@YJDave
Copy link
Author

YJDave commented Nov 9, 2017

Okay!!
Will update soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants